Added regex to remove inline oauth params from repo urls. #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
approved these changes
Nov 30, 2017
There was a problem hiding this comment.
Thanks for the fix. Looks great.
@screamerbg We should make a release of Mbed CLI with this fix after we merge it.
|
Why a regex and not a URL parser? Most URL parsers will parse the auth data out straight away, and there could be a URL that this regex will choke on. E.g. in JS: Easy to create new URL without the data. |
|
@janjongboom I updated this PR to use urlparse |
|
With the example from #569, and the code change from this PR: >>> ref = 'https://77f0469f687b8b085d25cee082df6a89009aa0ee:[email protected]/ARMmbed/mbed-os/#fc1836545dcc2fc86f03b01292b62bf2089f67c3'
>>> with_auth = urlparse(ref)
>>> print(with_auth._replace(netloc=with_auth.hostname).geturl())
https://github.com/ARMmbed/mbed-os/#fc1836545dcc2fc86f03b01292b62bf2089f67c3 |
|
Nice work y'all 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference bug #569