Skip to content

MIMXRT1050_EVK: Add USB support #13115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Conversation

mmahadevan108
Copy link
Contributor

Summary of changes

Add USB support for MXRT1050_EVK

Impact of changes

NONE

Migration actions required

NONE

Documentation

NONE

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@maclobdell

@mmahadevan108
Copy link
Contributor Author

TEST RESULTS BELOW:
mbedgt: test suite report:

target platform_name test suite result elapsed_time (sec) copy_method
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic OK 63.18 default
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid OK 25.66 default
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-msd OK 88.87 default
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial OK 32.24 default
mbedgt: test suite results: 4 OK
mbedgt: test case report:
target platform_name test suite test case passed failed
------------------------ ---------------- --------------------------------- ------------------------------------------------- -------- --------
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic endpoint test abort 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic endpoint test data correctness 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic endpoint test data toggle reset 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic endpoint test halt 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic endpoint test parallel transfers 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic endpoint test parallel transfers ctrl 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic usb control basic test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic usb control sizes test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic usb control stall test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic usb control stress test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic usb device reset test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic usb repeated construction destruction test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-basic usb soft reconnection test 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid Configuration descriptor, generic 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid Configuration descriptor, keyboard 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid Configuration descriptor, mouse 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid HID class descriptors, generic 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid HID class descriptors, keyboard 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid HID class descriptors, mouse 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid Raw input/output, 1-byte reports 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid Raw input/output, 20-byte reports 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-hid Raw input/output, 64-byte reports 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-msd mount/unmount and data test - Heap block device 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-msd mount/unmount test - Heap block device 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-msd storage initialization 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial CDC RX multiple bytes 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial CDC RX multiple bytes concurrent 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial CDC RX single bytes 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial CDC RX single bytes concurrent 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial CDC USB reconnect 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial CDC loopback 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial Serial USB reconnect 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial Serial getc 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial Serial line coding change 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial Serial printf/scanf 1 0
MIMXRT1050_EVK-GCC_ARM MIMXRT1050_EVK mbed-os-tests-usb_device-serial Serial terminal reopen 1 0
mbedgt: test case results: 36 OK
mbedgt: completed in 213.33 sec

@ciarmcom ciarmcom requested review from maclobdell and a team June 14, 2020 13:00
@ciarmcom
Copy link
Member

@mmahadevan108, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 15, 2020

Please review: travis-ci/licence_check — Needs review, 4 license issues found . SPDX missing in some new files

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add SPDX to new files where its not already

@mergify mergify bot added needs: CI and removed needs: work labels Jun 15, 2020
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest approval is for the changes, not the license, still to be fixed.

@mergify mergify bot added needs: work and removed needs: CI labels Jun 15, 2020
@mergify mergify bot dismissed 0xc0170’s stale review June 15, 2020 12:36

Pull request has been modified.

@mmahadevan108
Copy link
Contributor Author

Add SPDX to new files where its not already

I have added the SPDX to the 4 files highlighted.

0xc0170
0xc0170 previously approved these changes Jun 17, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Jun 17, 2020

CI started

@mergify mergify bot added needs: CI and removed needs: work labels Jun 17, 2020
@mbed-ci
Copy link

mbed-ci commented Jun 17, 2020

Test run: FAILED

Summary: 2 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

Signed-off-by: Mahesh Mahadevan <[email protected]>
Having Freescale and NXP macro causes compile from both
TARGET_Freescale and TARGET_NXP HAL folders.

Signed-off-by: Mahesh Mahadevan <[email protected]>
@mergify mergify bot dismissed 0xc0170’s stale review June 17, 2020 16:28

Pull request has been modified.

@mmahadevan108
Copy link
Contributor Author

@0xc0170 I have fixed the build issues seen,

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 17, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Jun 17, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 2
Build artifacts

@0xc0170 0xc0170 merged commit 29aa6d8 into ARMmbed:master Jun 18, 2020
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed needs: CI labels Jun 18, 2020
@adbridge adbridge added release-version: 6.1.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants