Skip to content

Refactor COMPONENT_FPGA_CI_TEST_SHIELD directory structure #13600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2020
Merged

Refactor COMPONENT_FPGA_CI_TEST_SHIELD directory structure #13600

merged 2 commits into from
Sep 17, 2020

Conversation

rajkan01
Copy link
Contributor

Summary of changes

  • Moved the COMPONENT_FPGA_CI_TEST_SHIELD directory from components/testing to mbed-os/features/frameworks
  • Restructured directory as per new directory layout.

Impact of changes

None.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Manual testing: (Build for K64F target with GCC_ARM toolchain):

  • Greentea tests: Full profile

Reviewers

@LDong-Arm @evedon

@rajkan01 rajkan01 changed the title Refactor COMPONENT_FPGA_CI_TEST_SHIELD as per new directory proposal Refactor COMPONENT_FPGA_CI_TEST_SHIELD directory structure Sep 11, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 11, 2020
@ciarmcom
Copy link
Member

@rajkan01, thank you for your changes.
@LDong-Arm @evedon @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from evedon, LDong-Arm and a team September 11, 2020 12:30
@jeromecoutant
Copy link
Collaborator

Not fully related to this PR, but
https://github.com/ARMmbed/mbed-os/blob/master/hal/tests/TESTS/mbed_hal_fpga_ci_test_shield/README.md
needs to be updated with all the current changes

Thx

LDong-Arm
LDong-Arm suggested changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rajkan01. .travis.yml needs to be updated as component doesn't exist anymore.

@rajkan01 rajkan01 force-pushed the fpga_test_shield_refactor branch from 2558921 to 1f9a20b Compare September 11, 2020 13:19
@rajkan01 rajkan01 force-pushed the fpga_test_shield_refactor branch from 1f9a20b to 2bc7bb7 Compare September 11, 2020 13:33
@rajkan01 rajkan01 requested a review from LDong-Arm September 11, 2020 14:05
LDong-Arm
LDong-Arm approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@LDong-Arm LDong-Arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rajkan01
Copy link
Contributor Author

@adbridge Could you review and start the CI for this PR

@mergify mergify bot added needs: CI and removed needs: work labels Sep 11, 2020
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 15, 2020

Waiting for the release to be complete, we will merge once done.

@0xc0170 0xc0170 merged commit ddaf37c into ARMmbed:master Sep 17, 2020
@mergify mergify bot removed the ready for merge label Sep 17, 2020
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adbridge adbridge adbridge approved these changes

@LDong-Arm LDong-Arm LDong-Arm approved these changes

@evedon evedon Awaiting requested review from evedon

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rajkan01 @ciarmcom @jeromecoutant @adbridge @mbed-ci @0xc0170 @LDong-Arm @mbedmain