Skip to content

Fix assertion on duplicate imported identifiers #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Fix assertion on duplicate imported identifiers #1124

merged 1 commit into from
Feb 27, 2020

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Feb 26, 2020

This is an attempt to fix #1117 by removing an assertion and providing a better (local) identifier reference for the emitted diagnostic.

@dcodeIO dcodeIO merged commit e6a668b into master Feb 27, 2020
@torch2424
Copy link
Contributor

Thanks for fixing my small issue @dcodeIO 😄 👍

@dcodeIO dcodeIO deleted the issue-1117 branch March 15, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing and Exporting a class of the same name returns an undescriptive Error
2 participants