Skip to content

Validate modules by default #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2020
Merged

Validate modules by default #1258

merged 1 commit into from
May 9, 2020

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented May 9, 2020

Validation isn't that costly, and always good to do, and typically added to the command line to be sure. Hence this PR changes the --validate option to be enabled by default, making it opt-out with --noValidate.

@dcodeIO dcodeIO merged commit 1868f2e into master May 9, 2020
@dcodeIO dcodeIO deleted the cli-invert-validate branch May 14, 2020 21:11
ifyouseewendy added a commit to Shopify/shopify-cli that referenced this pull request Jul 23, 2020
* remove `--validate` as AS enables validation by default AssemblyScript/assemblyscript#1258
* add --use Date=` to get `Date` usage fail by AS compilation

Ticket: https://github.com/Shopify/script-service/issues/592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant