Skip to content

Add provided set to cli parser #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2020
Merged

Add provided set to cli parser #1273

merged 2 commits into from
May 14, 2020

Conversation

jtenner
Copy link
Contributor

@jtenner jtenner commented May 14, 2020

This will be useful in the following ways:

  1. Aspect and other projects that bootstrap the compiler can reuse the cli parser and reduce code size
  2. We can reuse this for when I get back around to asconfig
  3. Maybe other uses

This is a very small change too. Should provided be a Set<string>, or string[]?

dcodeIO
dcodeIO reviewed May 14, 2020
View reviewed changes
@dcodeIO dcodeIO merged commit 5bfd5c8 into AssemblyScript:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtenner @dcodeIO