Slightly improve pass pipeline #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcodeIO
reviewed
Oct 12, 2020
| @@ -1656,7 +1655,7 @@ export class Module { | |||
| passes.push("simplify-locals"); | |||
| passes.push("vacuum"); | |||
|
|
|||
| passes.push("inlining-optimizing"); | |||
| passes.push("inlining"); | |||
There was a problem hiding this comment.
Just curious: What's the different between inlining and inlining-optimizing? Is the latter unnecessary?
There was a problem hiding this comment.
It seems inlining-optimizing also apply constant propagation but only for specific part or something like this
1 task
|
Great news! Time of bootstrap compilation reduced from |
|
🎉 This PR is included in version 0.15.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
code-foldinglittle bit lower in pipeline.Remove and simplify some inline passes.
All this changes slightly improve codegen quality and increase optimization speed