Skip to content

Improve generated type defininitions for ASModule #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2020
Merged

Improve generated type defininitions for ASModule #1510

merged 2 commits into from
Oct 16, 2020

Conversation

MaxGraey
Copy link
Member

changes:

  • align assignments

  • BigInt -> bigint

  • type bool = any -> type bool = boolean | number

  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO October 16, 2020 14:36
dcodeIO
dcodeIO approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) with a nit: Pretty indentation doesn't seem overly useful in these generated files, since everything else doesn't attempt to look good anyway.

@dcodeIO dcodeIO merged commit 5b0a7ae into AssemblyScript:master Oct 16, 2020
@dcodeIO
Copy link
Member

dcodeIO commented Oct 16, 2020

👍

@MaxGraey MaxGraey deleted the improve-module-defs branch October 16, 2020 22:23
@github-actions
Copy link

🎉 This PR is included in version 0.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO