Skip to content

chore: remove unused tslint and replace deprecated deepEqual #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NOTICE
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ under the licensing terms detailed in LICENSE:
* Valeria Viana Gusmao <[email protected]>
* Gabor Greif <[email protected]>
* Martin Fredriksson <[email protected]>
* yjhmelody <[email protected]>

Portions of this software are derived from third-party works licensed under
the following terms:
Expand Down
2 changes: 0 additions & 2 deletions bin/asc
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#!/usr/bin/env node

/* tslint:disable */

const tailArgs = process.argv.indexOf("--");
if (~tailArgs) {
require("child_process").spawnSync(
Expand Down
2 changes: 0 additions & 2 deletions bin/asinit
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#!/usr/bin/env node

/* tslint:disable */

const fs = require("fs");
const path = require("path");
const colors = require("../cli/util/colors");
Expand Down
60 changes: 30 additions & 30 deletions lib/loader/tests/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ function test(file) {
assert(exports.__instanceof(ref, exports.INT32ARRAY_ID));

// should be able to get the values of an array
assert.deepEqual(exports.__getArray(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), arr);

// should be able to get a view on an array
assert.deepEqual(exports.__getArrayView(ref), new Int32Array(arr));
assert.deepStrictEqual(exports.__getArrayView(ref), new Int32Array(arr));

// should be able to sum up its values
assert.strictEqual(exports.sum(ref), arr.reduce((a, b) => (a + b) | 0, 0) | 0);
Expand All @@ -79,10 +79,10 @@ function test(file) {
assert(exports.__instanceof(ref, exports.STATICARRAYI32_ID));

// should be able to get the values of an array
assert.deepEqual(exports.__getArray(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), arr);

// should be able to get a view on an array
assert.deepEqual(exports.__getArrayView(ref), new Int32Array(arr));
assert.deepStrictEqual(exports.__getArrayView(ref), new Int32Array(arr));

// should be able to sum up its values
assert.strictEqual(exports.sumStatic(ref), arr.reduce((a, b) => (a + b) | 0, 0) | 0);
Expand All @@ -97,21 +97,21 @@ function test(file) {
let arrU8Arr = new Uint8Array([0, 1, 2]);
let refU8Arr = module.__retain(module.__newUint8Array(arrU8Arr));
assert(module.__instanceof(refU8Arr, module.UINT8ARRAY_ID));
assert.deepEqual(module.__getUint8Array(refU8Arr), arrU8Arr);
assert.deepStrictEqual(module.__getUint8Array(refU8Arr), arrU8Arr);
module.__release(refU8Arr);
try { module.__release(refU8Arr); assert(false); } catch (e) {};

let arrU16Arr = new Uint16Array([0, 0x7FFF, 0xFFFF]);
let refU16Arr = module.__retain(module.__newUint16Array(arrU16Arr));
assert(module.__instanceof(refU16Arr, module.UINT16ARRAY_ID));
assert.deepEqual(module.__getUint16Array(refU16Arr), arrU16Arr);
assert.deepStrictEqual(module.__getUint16Array(refU16Arr), arrU16Arr);
module.__release(refU16Arr);
try { module.__release(refU16Arr); assert(false); } catch (e) {};

let arrI16Arr = new Int16Array([0, -1, -2]);
let refI16Arr = module.__retain(module.__newInt16Array(arrI16Arr));
assert(module.__instanceof(refI16Arr, module.INT16ARRAY_ID));
assert.deepEqual(module.__getInt16Array(refI16Arr), arrI16Arr);
assert.deepStrictEqual(module.__getInt16Array(refI16Arr), arrI16Arr);
module.__release(refI16Arr);
try { module.__release(refI16Arr); assert(false); } catch (e) {};
}
Expand All @@ -123,9 +123,9 @@ function test(file) {
let arr = new Uint8Array(values);
let ref = exports.__retain(exports.__newArray(exports.UINT8ARRAY_ID, arr));
assert(exports.__instanceof(ref, exports.UINT8ARRAY_ID));
assert.deepEqual(exports.__getUint8Array(ref), arr);
assert.deepEqual(exports.__getUint8ArrayView(ref), arr);
assert.deepEqual(exports.__getArray(ref), values);
assert.deepStrictEqual(exports.__getUint8Array(ref), arr);
assert.deepStrictEqual(exports.__getUint8ArrayView(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), values);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -135,7 +135,7 @@ function test(file) {
let arr = [0, 255, 127];
let ref = exports.__retain(exports.__newArray(exports.STATICARRAYU8_ID, arr));
assert(exports.__instanceof(ref, exports.STATICARRAYU8_ID));
assert.deepEqual(exports.__getArray(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), arr);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -146,9 +146,9 @@ function test(file) {
let arr = new Int16Array(values);
let ref = exports.__retain(exports.__newArray(exports.INT16ARRAY_ID, arr));
assert(exports.__instanceof(ref, exports.INT16ARRAY_ID));
assert.deepEqual(exports.__getInt16Array(ref), arr);
assert.deepEqual(exports.__getInt16ArrayView(ref), arr);
assert.deepEqual(exports.__getArray(ref), [0, -1, -255]);
assert.deepStrictEqual(exports.__getInt16Array(ref), arr);
assert.deepStrictEqual(exports.__getInt16ArrayView(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), [0, -1, -255]);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -158,7 +158,7 @@ function test(file) {
let arr = [0, 0xFFFF, -0x00FF];
let ref = exports.__retain(exports.__newArray(exports.STATICARRAYI16_ID, arr));
assert(exports.__instanceof(ref, exports.STATICARRAYI16_ID));
assert.deepEqual(exports.__getArray(ref), [0, -1, -255]);
assert.deepStrictEqual(exports.__getArray(ref), [0, -1, -255]);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -169,9 +169,9 @@ function test(file) {
let arr = new Uint32Array(values);
let ref = exports.__retain(exports.__newArray(exports.UINT32ARRAY_ID, arr));
assert(exports.__instanceof(ref, exports.UINT32ARRAY_ID));
assert.deepEqual(exports.__getUint32Array(ref), arr);
assert.deepEqual(exports.__getUint32ArrayView(ref), arr);
assert.deepEqual(exports.__getArray(ref), values);
assert.deepStrictEqual(exports.__getUint32Array(ref), arr);
assert.deepStrictEqual(exports.__getUint32ArrayView(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), values);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -181,7 +181,7 @@ function test(file) {
let arr = [1, -1 >>> 0, 0x80000000];
let ref = exports.__retain(exports.__newArray(exports.STATICARRAYU32_ID, arr));
assert(exports.__instanceof(ref, exports.STATICARRAYU32_ID));
assert.deepEqual(exports.__getArray(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), arr);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -192,9 +192,9 @@ function test(file) {
let arr = new Float32Array(values);
let ref = exports.__retain(exports.__newArray(exports.FLOAT32ARRAY_ID, arr));
assert(exports.__instanceof(ref, exports.FLOAT32ARRAY_ID));
assert.deepEqual(exports.__getFloat32Array(ref), arr);
assert.deepEqual(exports.__getFloat32ArrayView(ref), arr);
assert.deepEqual(exports.__getArray(ref), values);
assert.deepStrictEqual(exports.__getFloat32Array(ref), arr);
assert.deepStrictEqual(exports.__getFloat32ArrayView(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), values);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -204,7 +204,7 @@ function test(file) {
let arr = [0.0, 1.5, 2.5];
let ref = exports.__retain(exports.__newArray(exports.STATICARRAYF32_ID, arr));
assert(exports.__instanceof(ref, exports.STATICARRAYF32_ID));
assert.deepEqual(exports.__getArray(ref), arr);
assert.deepStrictEqual(exports.__getArray(ref), arr);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand All @@ -215,7 +215,7 @@ function test(file) {
let ref = exports.__retain(exports.__newArray(exports.ARRAYI32_ID, arr));
assert(exports.__instanceof(ref, exports.ARRAYI32_ID));
exports.changeLength(ref, 3);
assert.deepEqual(exports.__getArray(ref), [1, 2, 3]);
assert.deepStrictEqual(exports.__getArray(ref), [1, 2, 3]);
exports.__release(ref);
try { exports.__release(ref); assert(false); } catch (e) { /* nop */ }
}
Expand Down Expand Up @@ -254,9 +254,9 @@ function test(file) {
{
let ptr = exports.__retain(exports.__newArray(exports.FLOAT32ARRAY_ID, [1, 2, 3]));
let view = exports.__getArrayView(ptr);
assert.deepEqual(view, new Float32Array([1, 2, 3]));
assert.deepStrictEqual(view, new Float32Array([1, 2, 3]));
exports.modifyFloat32Array(ptr, 0, 4);
assert.deepEqual(view, new Float32Array([4, 2, 3]));
assert.deepStrictEqual(view, new Float32Array([4, 2, 3]));
exports.__release(ptr);
}

Expand All @@ -265,13 +265,13 @@ function test(file) {
let ptr = exports.newFloat32Array(3); // returns are pre-retained
let view = exports.__getFloat32ArrayView(ptr);
let arr = exports.__getFloat32Array(ptr);
assert.deepEqual(view, new Float32Array([0, 0, 0]));
assert.deepEqual(arr, new Float32Array([0, 0, 0]));
assert.deepStrictEqual(view, new Float32Array([0, 0, 0]));
assert.deepStrictEqual(arr, new Float32Array([0, 0, 0]));
exports.modifyFloat32Array(ptr, 0, 3);
exports.modifyFloat32Array(ptr, 1, 2);
exports.modifyFloat32Array(ptr, 2, 1);
assert.deepEqual(view, new Float32Array([3, 2, 1]));
assert.deepEqual(arr, new Float32Array([0, 0, 0]));
assert.deepStrictEqual(view, new Float32Array([3, 2, 1]));
assert.deepStrictEqual(arr, new Float32Array([0, 0, 0]));
exports.__release(ptr);
}
}
Expand Down
2 changes: 0 additions & 2 deletions scripts/build-diagnostics.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ var header = `/**
* @license Apache-2.0
*/

/* tslint:disable:max-line-length */

`.replace(/\r\n/g, "\n");

var sb = [ header ];
Expand Down
2 changes: 0 additions & 2 deletions src/diagnosticMessages.generated.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
* @license Apache-2.0
*/

/* tslint:disable:max-line-length */

/** Enum of available diagnostic codes. */
export enum DiagnosticCode {
Not_implemented_0 = 100,
Expand Down
2 changes: 0 additions & 2 deletions std/assembly/bindings/wasi_snapshot_preview1.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Phase: wasi_snapshot_preview1
// See: https://github.com/WebAssembly/WASI/tree/master/phases/snapshot/witx

/* tslint:disable:max-line-length */

// helper types to be more explicit
type char = u8;
type ptr<T> = usize; // all pointers are usize'd
Expand Down
2 changes: 0 additions & 2 deletions std/assembly/bindings/wasi_unstable.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Phase: wasi_unstable / wasi_snapshot_preview0
// See: https://github.com/WebAssembly/WASI/tree/master/phases/old/snapshot_0/witx

/* tslint:disable:max-line-length */

// helper types to be more explicit
type char = u8;
type ptr<T> = usize; // all pointers are usize'd
Expand Down
22 changes: 11 additions & 11 deletions tests/cli/options.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,32 +18,32 @@ const config = {

// Present in both should concat
var merged = optionsUtil.merge(config, { enable: ["a"] }, { enable: ["b"] });
assert.deepEqual(merged.enable, ["a", "b"]);
assert.deepStrictEqual(merged.enable, ["a", "b"]);

merged = optionsUtil.merge(config, { enable: ["a"] }, { enable: ["a", "b"] });
assert.deepEqual(merged.enable, ["a", "b"]);
assert.deepStrictEqual(merged.enable, ["a", "b"]);

// Mutually exclusive should exclude
merged = optionsUtil.merge(config, { enable: ["a", "b"] }, { disable: ["a", "c"] });
assert.deepEqual(merged.enable, ["a", "b"]);
assert.deepEqual(merged.disable, ["c"]);
assert.deepStrictEqual(merged.enable, ["a", "b"]);
assert.deepStrictEqual(merged.disable, ["c"]);

merged = optionsUtil.merge(config, { disable: ["a", "b"] }, { enable: ["a", "c"] });
assert.deepEqual(merged.enable, ["c"]);
assert.deepEqual(merged.disable, ["a", "b"]);
assert.deepStrictEqual(merged.enable, ["c"]);
assert.deepStrictEqual(merged.disable, ["a", "b"]);

// Populating defaults should work after the fact
merged = optionsUtil.addDefaults(config, {});
assert.deepEqual(merged.other, ["x"]);
assert.deepStrictEqual(merged.other, ["x"]);

merged = optionsUtil.addDefaults(config, { other: ["y"] });
assert.deepEqual(merged.other, ["y"]);
assert.deepStrictEqual(merged.other, ["y"]);

// Complete usage test
var result = optionsUtil.parse(["--enable", "a", "--disable", "b"], config, false);
merged = optionsUtil.merge(config, result.options, { enable: ["b", "c"] });
merged = optionsUtil.merge(config, merged, { disable: ["a", "d"] });
optionsUtil.addDefaults(config, merged);
assert.deepEqual(merged.enable, ["a", "c"]);
assert.deepEqual(merged.disable, ["b", "d"]);
assert.deepEqual(merged.other, ["x"]);
assert.deepStrictEqual(merged.enable, ["a", "c"]);
assert.deepStrictEqual(merged.disable, ["b", "d"]);
assert.deepStrictEqual(merged.other, ["x"]);
2 changes: 0 additions & 2 deletions tests/compiler/import.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* tslint:disable:no-duplicate-imports */

import {
add,
sub as sub,
Expand Down