Skip to content

issue-1617 Adding wrap definition. #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 18, 2021
Merged

issue-1617 Adding wrap definition. #1618

merged 8 commits into from
Jan 18, 2021

Conversation

forcepusher
Copy link
Contributor

@forcepusher forcepusher commented Jan 10, 2021 •
edited
Loading

Fixes #1617

  • I've read the contributing guidelines

@forcepusher
Copy link
Contributor Author

forcepusher commented Jan 10, 2021 •
edited
Loading

That wraps it up.
image

Should I squish the commits ?

@forcepusher forcepusher mentioned this pull request Jan 10, 2021
Closed
dcodeIO
dcodeIO reviewed Jan 10, 2021
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think we should not generate the definition for interfaces, as these are merely types currently.

@forcepusher @dcodeIO
Update src/definitions.ts
4c500e5 
Co-authored-by: Daniel Wirtz <[email protected]>
@forcepusher
Copy link
Contributor Author

forcepusher commented Jan 11, 2021 •
edited
Loading

@dcodeIO Got it. Maybe I should reference https://github.com/AssemblyScript/assemblyscript/blob/master/src/common.ts#L121 as well instead of hardcoding the usize into the string ?
Otherwise I'm fine with it as is.

dcodeIO
dcodeIO reviewed Jan 18, 2021
View reviewed changes
dcodeIO
dcodeIO reviewed Jan 18, 2021
View reviewed changes
@forcepusher @dcodeIO
Merging 2 pushes together.
711a71e 
Co-authored-by: Daniel Wirtz <[email protected]>
@dcodeIO dcodeIO merged commit f06b68f into AssemblyScript:master Jan 18, 2021
@dcodeIO
Copy link
Member

dcodeIO commented Jan 18, 2021

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing wrap() method in generated definition files. Prevents compilation.
2 participants
@forcepusher @dcodeIO