Skip to content

Transform glob entries into paths #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jerrygreen
Copy link

@jerrygreen
Copy link
Author

jerrygreen commented Mar 6, 2021

@dcodeIO can you tell me what is this LIBRARY_PREFIX.valueOf() and why LIBRARY_PREFIX might be undefined that is making a test fail? I don't quite understand this...

 /home/runner/work/assemblyscript/assemblyscript/cli/asc.js:175
exports.libraryPrefix = __getString(assemblyscript.LIBRARY_PREFIX.valueOf());
                                                                  ^
TypeError: Cannot read property 'valueOf' of undefined

But anyway this asconfig.json actually works now:

{
  "entries": ["./src/**/*.as.ts"]
}

@dcodeIO
Copy link
Member

dcodeIO commented Mar 6, 2021

LIBRARY_PREFIX can be an exported WebAssembly global, and the proper way to get its value is to use valueOf, which is specified to return the primitive value of an object, so also works on strings. Not sure why it would fail.

@jerrygreen
Copy link
Author

Ok, I don't know either, but I can say compiler actually works. I temporarily use my fork in my project like this:

// package.json
{
  "devDependencies": {
    "assemblyscript": "https://github.com/jerrygreen/assemblyscript/tarball/jerrygreen",
  }
}

Which accumulates both this change and also: #1705. And I'm ok with it currently. Maybe I'll figure out what's wrong with this change later. Or not. Will see :)

Copy link

github-actions bot commented Dec 3, 2023

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 3, 2023
Copy link

This PR has been automatically closed due to lack of recent activity, but feel free to reopen it as long as you merge in the main branch afterwards.

@github-actions github-actions bot closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asconfig: entries cannot include * and ** wildcards
2 participants