Skip to content

feat: add NonNullable builtin type to remove null from type union #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 8, 2021
Merged

feat: add NonNullable builtin type to remove null from type union #1875

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8aa0114
feat: add NonNullable builtin type to remove null from T
May 29, 2021
9851d6c
fix: linting
May 29, 2021
f5a6c31
Update src/resolver.ts
May 29, 2021
fac3fec
fix: update deps locally and finish renaming refactor
May 29, 2021
9810f2f
nit: simplify test
Jun 1, 2021
9198cf0
fix: remove old test generated by accident with --create
Jun 1, 2021
e9e85ae
fix: remove old artifacts from git cache
Jun 1, 2021
7896091
fix: rename again
Jun 1, 2021
706894c
feat: add second function to show casting works
Jun 1, 2021
a813892
Update src/resolver.ts
Jun 7, 2021
f9790bb
nit: refactor ensureOneTypeArgument
Jun 7, 2021
c6a7092
fix: make `!= 1`
Jun 7, 2021
a5cb27b
fix: remove one check
Jun 7, 2021
44d7b67
chore: rename internally `nonnull` and make an alias for `NonNullable`
Jun 7, 2021
3142241
fix: revert package-lock.json
Jun 7, 2021
510d52e
fix: revert nullable test
Jun 7, 2021
a715785
fix: add line at end of file
Jun 7, 2021
4411373
fix: add new line to test file
Jun 7, 2021
a44bf8f
chore: add newline to end of files that are missing one
Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3347,11 +3347,10 @@ export class Resolver extends DiagnosticEmitter {
node: NamedTypeNode,
/** How to proceed with eventual diagnostics. */
reportMode: ReportMode = ReportMode.REPORT
): TypeNode | null {
): TypeNode | null {
var typeArgumentNodes = node.typeArguments;
if (!typeArgumentNodes || typeArgumentNodes.length != 1) {
let numTypeArguments = 0;
if (typeArgumentNodes) numTypeArguments = typeArgumentNodes.length;
const numTypeArguments = typeArgumentNodes ? typeArgumentNodes.length : 0;
if (typeArgumentNodes == null || numTypeArguments != 0) {
if (reportMode == ReportMode.REPORT) {
this.error(
DiagnosticCode.Expected_0_type_arguments_but_got_1,
Expand Down