Skip to content

Support floats in SIMD load/store lane/zero #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2021
Merged

Conversation

dcodeIO
Copy link
Member

@dcodeIO dcodeIO commented Jun 1, 2021

The instructions

  • v128.load32_lane, v128.store32_lane, v128.load32_zero
  • v128.load64_lane, v128.store64_lane, v128.load64_zero

can be used for the types f32 respectively f64 as well.

  • I've read the contributing guidelines

@dcodeIO dcodeIO changed the title Support floats in SIMD load/store lane Support floats in SIMD load/store lane/zero Jun 1, 2021
@dcodeIO dcodeIO requested a review from MaxGraey June 1, 2021 14:18
@MaxGraey
Copy link
Member

MaxGraey commented Jun 1, 2021

Could you add some tests?

@dcodeIO
Copy link
Member Author

dcodeIO commented Jun 1, 2021

It's the same for i32 respectively i64, and there are no dedicated f32x4 respectively f64x2 instructions for these (just the generic 32 respectively 64 variants). Would you still prefer some?

Copy link
Member

@MaxGraey MaxGraey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, LGTM

@dcodeIO dcodeIO merged commit 39a99f0 into master Jun 1, 2021
@dcodeIO dcodeIO deleted the loadstorelane-float branch June 1, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants