Fixed stdlib builtins not working with typedoc #1894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is just something I noticed when working on the Fastly AS SDK.
It seems like in version
0.18.13
, we introduced a change in which caused a type error, as we try to assignvoid
to ani32
, andi31ref
:I got the error above when running typedoc on version
0.19.1
, but it works again on0.18.12
. So, I assume unreachable is the instruction that causes things to crash. So instead of returning void, I still call the function, but return a "void number" (0), which I assume is the expected behavior?With this fix, things start working again in the type system:
Thanks to whoever picks up this review! 😄 🎉
cc @dcodeIO @MaxGraey 😄