Fixed stdlib builtins not working with typedoc

[torch2424]

Hello!

This is just something I noticed when working on the Fastly AS SDK.

It seems like in version 0.18.13, we introduced a change in which caused a type error, as we try to assign void to an i32, and i31ref:

I got the error above when running typedoc on version 0.19.1, but it works again on 0.18.12. So, I assume unreachable is the instruction that causes things to crash. So instead of returning void, I still call the function, but return a "void number" (0), which I assume is the expected behavior?

With this fix, things start working again in the type system:

Thanks to whoever picks up this review! 😄 🎉

cc @dcodeIO @MaxGraey 😄

[MaxGraey]

Thanks!

[dcodeIO]

Hmm, interesting. Unreachable is currently typed as

declare function unreachable(): never;

and in AS itself is an expression of any type. I guess the following doesn't work either?

static new(value: i32): i31ref { return <i31ref>unreachable(); }

static get(i31expr: i31ref): i32 { return <i32>unreachable(); }

---

Ah, I see now. In this particular file, it picks up the AS-internal builtin definition of unreachable, which is

// @ts-ignore: decorator
@unsafe @builtin
export declare function unreachable(): void;

Changing the void there to auto gets rid of one of the errors, and the other can be worked around as well:

static new(value: i32): i31ref { return changetype<i31ref>(unreachable()); }

static get(i31expr: i31ref): i32 { return unreachable(); }

Wondering if that would be a preferable fix?

(other than that it's kinda hilarious where just naming an instruction i31.new (new is a keyword) leads here, since if it would be named i31.create instead, we could just use a proper namespace, heh - we could propose renaming the instruction, as I would assume similar workarounds, if possible at all, are necessary in other languages as well)

[torch2424]

Thank you for the review @MaxGraey ! 😄

And I went ahead and made your requested changes @dcodeIO ! 😄 It totally worked for me, thank you! 😄

[torch2424]

Thanks for the review y'all @dcodeIO @MaxGraey ! Merging! 😄