Skip to content

Simplify wrap polyfill in portable #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 26, 2021
Merged

Simplify wrap polyfill in portable #2177

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3795346
simplify wrap polyfill in portable
MaxGraey Dec 19, 2021
24d703c
remove writable: false due to it's already default value
MaxGraey Dec 19, 2021
510534b
use configurable: true
MaxGraey Dec 22, 2021
9a2395b
new approach for ctz
MaxGraey Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
130 changes: 42 additions & 88 deletions std/portable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,94 +21,93 @@ if (typeof globalScope.ASC_TARGET === "undefined") {
Object.defineProperties(
globalScope["i8"] = function i8(value) { return value << 24 >> 24; },
{
"MIN_VALUE": { value: -128, writable: false },
"MAX_VALUE": { value: 127, writable: false }
"MIN_VALUE": { value: -128 },
"MAX_VALUE": { value: 127 }
}
);

Object.defineProperties(
globalScope["i16"] = function i16(value) { return value << 16 >> 16; },
{
"MIN_VALUE": { value: -32768, writable: false },
"MAX_VALUE": { value: 32767, writable: false }
"MIN_VALUE": { value: -32768 },
"MAX_VALUE": { value: 32767 }
}
);

Object.defineProperties(
globalScope["i32"] = globalScope["isize"] = function i32(value) { return value | 0; },
{
"MIN_VALUE": { value: -2147483648, writable: false },
"MAX_VALUE": { value: 2147483647, writable: false }
"MIN_VALUE": { value: -2147483648 },
"MAX_VALUE": { value: 2147483647 }
}
);

Object.defineProperties(
globalScope["u8"] = function u8(value) { return value & 0xff; },
{
"MIN_VALUE": { value: 0, writable: false },
"MAX_VALUE": { value: 255, writable: false }
"MIN_VALUE": { value: 0 },
"MAX_VALUE": { value: 255 }
}
);

Object.defineProperties(
globalScope["u16"] = function u16(value) { return value & 0xffff; },
{
"MIN_VALUE": { value: 0, writable: false },
"MAX_VALUE": { value: 65535, writable: false }
"MIN_VALUE": { value: 0 },
"MAX_VALUE": { value: 65535 }
}
);

Object.defineProperties(
globalScope["u32"] = globalScope["usize"] = function u32(value) { return value >>> 0; },
{
"MIN_VALUE": { value: 0, writable: false },
"MAX_VALUE": { value: 4294967295, writable: false }
"MIN_VALUE": { value: 0 },
"MAX_VALUE": { value: 4294967295 }
}
);

Object.defineProperties(
globalScope["bool"] = function bool(value) { return !!value; },
{
"MIN_VALUE": { value: false, writable: false },
"MAX_VALUE": { value: true, writable: false }
"MIN_VALUE": { value: false },
"MAX_VALUE": { value: true }
}
);

Object.defineProperties(
globalScope["f32"] = function f32(value) { return Math.fround(value); },
{
"EPSILON": { value: 1.1920928955078125e-07, writable: false },
"MIN_VALUE": { value: 1.401298464324817e-45, writable: false },
"MAX_VALUE": { value: 3.4028234663852886e+38, writable: false },
"MIN_NORMAL_VALUE": { value: 1.1754943508222875e-38, writable: false },
"MIN_SAFE_INTEGER": { value: -16777215, writable: false },
"MAX_SAFE_INTEGER": { value: 16777215, writable: false },
"POSITIVE_INFINITY": { value: Infinity, writable: false },
"NEGATIVE_INFINITY": { value: -Infinity, writable: false },
"NaN": { value: NaN, writable: false }
"EPSILON": { value: 1.1920928955078125e-07 },
"MIN_VALUE": { value: 1.401298464324817e-45 },
"MAX_VALUE": { value: 3.4028234663852886e+38 },
"MIN_NORMAL_VALUE": { value: 1.1754943508222875e-38 },
"MIN_SAFE_INTEGER": { value: -16777215 },
"MAX_SAFE_INTEGER": { value: 16777215 },
"POSITIVE_INFINITY": { value: Infinity },
"NEGATIVE_INFINITY": { value: -Infinity },
"NaN": { value: NaN }
}
);

Object.defineProperties(
globalScope["f64"] = function f64(value) { return +value; },
{
"EPSILON": { value: 2.2204460492503131e-016, writable: false },
"MIN_VALUE": { value: 5e-324, writable: false },
"MAX_VALUE": { value: 1.7976931348623157e+308, writable: false },
"MIN_NORMAL_VALUE": { value: 2.2250738585072014e-308, writable: false },
"MIN_SAFE_INTEGER": { value: -9007199254740991, writable: false },
"MAX_SAFE_INTEGER": { value: 9007199254740991, writable: false },
"POSITIVE_INFINITY": { value: Infinity, writable: false },
"NEGATIVE_INFINITY": { value: -Infinity, writable: false },
"NaN": { value: NaN, writable: false }
"EPSILON": { value: 2.2204460492503131e-016 },
"MIN_VALUE": { value: 5e-324 },
"MAX_VALUE": { value: 1.7976931348623157e+308 },
"MIN_NORMAL_VALUE": { value: 2.2250738585072014e-308 },
"MIN_SAFE_INTEGER": { value: -9007199254740991 },
"MAX_SAFE_INTEGER": { value: 9007199254740991 },
"POSITIVE_INFINITY": { value: Infinity },
"NEGATIVE_INFINITY": { value: -Infinity },
"NaN": { value: NaN }
}
);

globalScope["clz"] = Math.clz32;

globalScope["ctz"] = function ctz(value) {
var c = Math.clz32(value & -value);
return value ? 31 - c : c;
return 32 - Math.clz32(~value & (value - 1));
};

globalScope["popcnt"] = function popcnt(value) {
Expand Down Expand Up @@ -306,6 +305,15 @@ if (typeof globalScope.ASC_TARGET === "undefined") {
configurable: true
});
}

if (Ctr != Array) {
Object.defineProperty(Ctr, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Ctr(buffer, byteOffset, length);
},
configurable: true
});
}
});

globalScope["isInteger"] = Number.isInteger;
Expand Down Expand Up @@ -388,60 +396,6 @@ if (typeof globalScope.ASC_TARGET === "undefined") {
if (n) message += Array.prototype.slice.call(arguments, 2, 2 + n);
console.error("trace: " + message);
};

Object.defineProperty(Int8Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Int8Array(buffer, byteOffset, length);
}
});

Object.defineProperty(Uint8Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Uint8Array(buffer, byteOffset, length);
}
});

Object.defineProperty(Uint8ClampedArray, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Uint8ClampedArray(buffer, byteOffset, length);
}
});

Object.defineProperty(Int16Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Int16Array(buffer, byteOffset, length);
}
});

Object.defineProperty(Uint16Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Uint16Array(buffer, byteOffset, length);
}
});

Object.defineProperty(Int32Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Int32Array(buffer, byteOffset, length);
}
});

Object.defineProperty(Uint32Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Uint32Array(buffer, byteOffset, length);
}
});

Object.defineProperty(Float32Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Float32Array(buffer, byteOffset, length);
}
});

Object.defineProperty(Float64Array, "wrap", {
value: function wrap(buffer, byteOffset, length) {
return new Float64Array(buffer, byteOffset, length);
}
});
} else {
console.warn("compiler mismatch: std/portable included twice");
}