Skip to content

use faster clamping for Uint8ClampedArray #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 22, 2019
Merged

use faster clamping for Uint8ClampedArray #422

merged 17 commits into from
Feb 22, 2019

Conversation

MaxGraey
Copy link
Member

No description provided.

@MaxGraey MaxGraey requested a review from dcodeIO January 15, 2019 16:54
dcodeIO
dcodeIO reviewed Jan 15, 2019
View reviewed changes
@MaxGraey
Copy link
Member Author

MaxGraey commented Jan 15, 2019 •
edited
Loading

I figure outing new byte clamp approach also smaller than min/max so now it uses always except when opt level == 0

@MaxGraey
Copy link
Member Author

MaxGraey commented Feb 7, 2019 •
edited
Loading

Also ready to merge if no more suggestions

@MaxGraey
Copy link
Member Author

Also synced with master

@dcodeIO
Copy link
Member

dcodeIO commented Feb 22, 2019

Suggesting to use the faster version in any case as size difference seems to be minimal (there is no int min/max anyway and these become selects), and putting it into the overloads directly, removing the helper.

@MaxGraey
Copy link
Member Author

Ready!

@dcodeIO dcodeIO merged commit ed97672 into AssemblyScript:master Feb 22, 2019
@dcodeIO
Copy link
Member

dcodeIO commented Feb 22, 2019

Thanks! :)

@MaxGraey MaxGraey deleted the improve-typedarray-clamp branch February 22, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO