Skip to content

Fix inherited netty dependency version to 4.0.36.Final #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Spikhalskiy
Copy link
Contributor

@Spikhalskiy Spikhalskiy commented May 17, 2016

Suggested patch for Issue #1156

@Spikhalskiy Spikhalskiy changed the title Fix inherited netty dependency version to 4.0.36.Final #1156 Fix inherited netty dependency version to 4.0.36.Final May 17, 2016
@Spikhalskiy Spikhalskiy changed the title #1156 Fix inherited netty dependency version to 4.0.36.Final Fix inherited netty dependency version to 4.0.36.Final May 17, 2016
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-handler</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes are useless. Dependency management in parent should suffice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, fixed

@Spikhalskiy Spikhalskiy force-pushed the netty-consistent-version branch from 515bdd9 to 233bb20 Compare May 17, 2016 14:37
@slandelle slandelle added this to the 2.0.3 milestone May 17, 2016
@slandelle slandelle merged commit ffb1820 into AsyncHttpClient:master May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants