Skip to content

Added Automatic-Module-Name #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 27, 2019
Merged

Added Automatic-Module-Name #1664

merged 2 commits into from
Sep 27, 2019

Conversation

doom369
Copy link
Contributor

@doom369 doom369 commented Sep 27, 2019

Add Automatic-Module-Name to the manifest of builded jar and updated the maven-jar-plugin version. This is required to avoid warnings during the build of the systems that switched to the Java 9 modules.

@slandelle
Copy link
Contributor

slandelle commented Sep 27, 2019

I'm not familiar with Java modules, but are you sure this is correct?
I would expect each artifact to have its own module name instead of hardcoding org.asynchttpclient.

How things are done in Netty:

@doom369
Copy link
Contributor Author

doom369 commented Sep 27, 2019

@slandelle you are right. I missed you have multiple modules.

@doom369
Copy link
Contributor Author

doom369 commented Sep 27, 2019

Pushed the fix. I can't check locally it is correct configuration right now (due to another non-related build errors).

@slandelle slandelle merged commit f4c5bef into AsyncHttpClient:master Sep 27, 2019
@slandelle
Copy link
Contributor

Thanks!

@doom369
Copy link
Contributor Author

doom369 commented Sep 27, 2019

Thank you as well :)!

@slandelle slandelle added this to the 2.10.3 milestone Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants