Address bug bash reports #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/E2E/AzureFunctions.PowerShell.Durable.SDK.E2E/DurableClientTests.cs
Outdated
Show resolved
Hide resolved
test/E2E/AzureFunctions.PowerShell.Durable.SDK.E2E/DurableClientTests.cs
Show resolved
Hide resolved
test/E2E/AzureFunctions.PowerShell.Durable.SDK.E2E/DurableClientTests.cs
Outdated
Show resolved
Hide resolved
…ntTests.cs Co-authored-by: Michael Peng <[email protected]>
Co-authored-by: Michael Peng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the following bugs from our bug bash:
Deeply nested object are not serialized completely davidmrdavid/durable-powershell-standalone-sdk-bug-bash#7
** To allow client inputs to be deeply serialized, we add a
-Depthparameter to ourConvertTo-Jsoncalls in the client functionsReturning array from activity doesn't get serialized properly davidmrdavid/durable-powershell-standalone-sdk-bug-bash#6
** To allow array outputs from activities to be serialized correctly, we change our serialization tooling from
Newtonsoft.JSONto the powershell built inConvertTo-JsonandConvertFom-Jsoncommands. We make this change inDTFxUtils.csOrdering of properties changes each time when hit orchestrator endpoint davidmrdavid/durable-powershell-standalone-sdk-bug-bash#3
** This was partially addressed by adding an
[ordered]annotation to our DF Client array return type. We still need to do the work of explicitly defining an ordering of the entries, but that can come in a separate PR>