Rewind API #163
Rewind API #163
Conversation
|
|
||
| request_url = f"{self._orchestration_bindings.rpc_base_url}" + path | ||
| else: | ||
| raise Exception("The Python SDK only supports RPC endpoints.") |
There was a problem hiding this comment.
nit: we could slightly clarify this by specifying what host.json settings need to be removed (i.e. localRpcEnabled)
There was a problem hiding this comment.
+1 - it's best to make exception messages like this actionable when possible.
There was a problem hiding this comment.
Indeed, I'm usually of this mindset, I just did not know myself what to disable/enable in host.json. I'll write something up with this!
| for code in [200, 202]: | ||
| mock_request = MockRequest( | ||
| expected_url=f"{RPC_BASE_URL}instances/{INSTANCE_ID}/rewind?reason={REASON}", | ||
| response=[202, ""]) |
There was a problem hiding this comment.
nit: should this line be response=[code,""])
There was a problem hiding this comment.
Ooh, silly me. That's a refactor gone wrong, thank you!
|
|
||
| @pytest.mark.asyncio | ||
| async def test_rewind_with_no_rpc_endpoint(binding_string): | ||
| """Tests the behaviour of rewind without an RPC endpoint / under the legacy HTTP enepoin5.""" |
There was a problem hiding this comment.
oh no. That's embarrassing. Sorry!
|
@ConnorMcMahon , @cgillum |
Implements the Rewind API for Python. Also adds unit tests equivalent to those in JS, found here.