Skip to content

Implemented out-of-proc error reporting schema #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2020
Merged

Implemented out-of-proc error reporting schema #196

merged 2 commits into from
Sep 17, 2020

Conversation

davidmrdavid
Copy link
Collaborator

@davidmrdavid davidmrdavid commented Sep 15, 2020 •
edited
Loading

Fixes: #118

This implements the out-of-proc error reporting strategy. It was a simple fix, requiring a simple string formatting procedure in one place, and then updating its affected tests.

@davidmrdavid davidmrdavid mentioned this pull request Sep 16, 2020
Closed
ConnorMcMahon
ConnorMcMahon reviewed Sep 17, 2020
View reviewed changes
Copy link

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can we just get a test for an exception that is thrown from user code in the orchestration just to verify that case? I don't think it will be handled any differently, just want to cover our bases.

@davidmrdavid
Copy link
Collaborator Author

Thanks! I'll add that test case shortly

davidmrdavid
davidmrdavid commented Sep 17, 2020
View reviewed changes
davidmrdavid
davidmrdavid commented Sep 17, 2020
View reviewed changes
ConnorMcMahon
ConnorMcMahon approved these changes Sep 17, 2020
View reviewed changes
Copy link

@ConnorMcMahon ConnorMcMahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

As long as you have verified the end-to-end behavior of this, I would say let's merge it!

@davidmrdavid davidmrdavid merged commit 6c25a78 into dev Sep 17, 2020
@davidmrdavid davidmrdavid mentioned this pull request Dec 3, 2020
Merged
@davidmrdavid davidmrdavid deleted the dajusto/error-processing branch March 9, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorMcMahon ConnorMcMahon ConnorMcMahon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly handle orchestration errors
2 participants
@davidmrdavid @ConnorMcMahon