Signal Entity #206
Merged
Signal Entity #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
reviewed
Oct 7, 2020
Comment on lines
67
to
71
|
|
||
| # TODO: json.loads inside parse_history_event is not recursvie | ||
| # investigate if response.result is used elsewhere, | ||
| # which probably requires another deserialization | ||
| result = json.loads(response.result) |
There was a problem hiding this comment.
We should make a ticket to follow-up on this one.
davidmrdavid
reviewed
Oct 7, 2020
Comment on lines
49
to
52
| if event_sent: | ||
| return | ||
|
|
||
| context.actions.append([new_action]) |
There was a problem hiding this comment.
Since signal_entity is weird in that it does not wait for a response, I think this portion would benefit from just a few comments explaining what's going on and why
davidmrdavid
approved these changes
Oct 7, 2020
|
This PR is automatically blocked because the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Signal Entity for Durable Python which builds on top of #184.
On a high level, this pr: