Disabling schema validation in AzureManagedIdentityProvider tests #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmrdavid
changed the title
wenhzha
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to: #209
Due to a recent Azure pipelines problem, some tests were not marked as failing on the PR linked above. This PR makes them pass.
The failing tests were error'ing because their output schema was augmented / changed as part of the PR above and so they failed a schema-validation step. We are currently not updating our reference schema due to not having an always up-to-date source of truth on schemas, so we have disabled that validation step for selected tests.
We have already disabled schema validation in a handful of other tests in this repo, but in the future we should revisit this by creating a singular out-of-proc schema that we can use to test all out-of-proc durable SDKs.