Skip to content

Serialize input for CallActivityWithRetryAction #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2020
Merged

Serialize input for CallActivityWithRetryAction #225

merged 2 commits into from
Nov 18, 2020

Conversation

carlvitzthum
Copy link
Contributor

See: #224

Changes

  • JSON serialize CallActivityWithRetryAction.input_ (based on CallActivityAction.input_`)
  • Added test_retries_with_serializable_input in test_retries.py
    • New tests fails without CallActivityWithRetryAction change, as expected

@ghost
Copy link

ghost commented Nov 18, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@davidmrdavid davidmrdavid self-requested a review November 18, 2020 21:06
davidmrdavid
davidmrdavid approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution ⚡

@davidmrdavid davidmrdavid merged commit af482d2 into Azure:dev Nov 18, 2020
@carlvitzthum carlvitzthum deleted the activity_retries branch November 19, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlvitzthum @davidmrdavid @cvitzthum-nasuni