Skip to content

Replace datetime.strptime for find_task_timer_created() #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2020
Merged

Replace datetime.strptime for find_task_timer_created() #228

merged 3 commits into from
Dec 2, 2020

Conversation

kemurayama
Copy link
Contributor

As I proposed #220, I replaced datetime.strptime() with dateutil.parser.parse() and deleted unnecessary constant.

@davidmrdavid davidmrdavid self-requested a review December 2, 2020 16:59
davidmrdavid
davidmrdavid approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@davidmrdavid davidmrdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your contribution, we should be releasing this soon!

@davidmrdavid davidmrdavid merged commit d95c56d into Azure:dev Dec 2, 2020
@kemurayama kemurayama deleted the timerfmt branch December 3, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmrdavid davidmrdavid davidmrdavid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kemurayama @davidmrdavid