Update java, python samples for param renames #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manvkaur
requested review from
vrdmr,
aishwaryabh,
cgillum and
gavin-aguiar
as code owners
3 tasks
|
nit: please update the Embeddings sample README -- the python sample provided still uses generic bindings. Otherwise, LGTM |
Nice catch, Thank you, README has been updated |
gavin-aguiar
approved these changes
May 13, 2025
hallvictoria
approved these changes
May 14, 2025
hallvictoria
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across multiple components, including version upgrades, developer metadata changes, and functional improvements in Java and Python samples. Key changes include dependency updates, adjustments to assistant and chat APIs, and improvements in Cosmos DB integration.
Version and Metadata Updates:
v0.19.0andv0.5.0with release dates (CHANGELOG.md,java-library/CHANGELOG.md) [1] [2].pom.xmlfiles, replacing existing developers with new ones (java-library/pom.xml).Dependency Updates:
azure-functions-java-library-openaito0.5.0-previewin multiple Java samples (samples/assistant/java/pom.xml,samples/chat/java/pom.xml,samples/embeddings/java/pom.xml) [1] [2].azure-identityand upgradedazure-functionsto>=1.24.0b1(samples/assistant/python/requirements.txt,samples/chat/python/requirements.txt) [1] [2].Functional Improvements:
ChatMessagewithAssistantMessagein Java assistant and chat APIs for better alignment with functionality (samples/assistant/java/src/main/java/com/azfs/AssistantApis.java,samples/chat/java/src/main/java/com/azfs/ChatBot.java) [1] [2].DefaultAzureCredentialandCosmosDbConnectionEndpointinstead of connection strings (samples/assistant/python/todo_manager.py,samples/assistant/python/local.settings.json) [1] [2].Code Formatting and Refactoring:
samples/assistant/python/assistant_apis.py,samples/chat/python/function_app.py) [1] [2].samples/embeddings/java/src/main/java/com/azfs/EmbeddingsGenerator.java).