-
Notifications
You must be signed in to change notification settings - Fork 53
OpenTelemetry support in worker #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b7fd7ee
Initial code changes before proto update
andystaples 261d74e
Update to latest protobuf (1.10.0-ptotofile)
andystaples 48c83b4
Initial PR review changes
andystaples 4589d8f
Expand testing
andystaples ecdfbf5
Additional PR changes
andystaples 59effad
Better naming in tests
andystaples 04302ca
Explicit naming for services class
andystaples 44a7296
Naming nit
andystaples File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
|
||
namespace Microsoft.Azure.Functions.PowerShellWorker.Utility | ||
{ | ||
internal class LoggingEventHandler | ||
{ | ||
private Action<string, string, Exception> _eventHandler = (a, b, c) => { }; | ||
|
||
public void Subscribe(Action<string, string, Exception> handler) | ||
{ | ||
_eventHandler = handler; | ||
} | ||
|
||
public void LogToHandlers(string level, string message, Exception exception = null) | ||
{ | ||
_eventHandler(level, message, exception); | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Text; | ||
using System.Threading.Tasks; | ||
|
||
namespace Microsoft.Azure.Functions.PowerShellWorker.OpenTelemetry | ||
{ | ||
internal interface IPowerShellServicesForOpenTelemetry | ||
{ | ||
bool? IsModuleLoaded(); | ||
void AddStartOpenTelemetryInvocationCommand(OpenTelemetryInvocationContext otelContext); | ||
void StopOpenTelemetryInvocation(OpenTelemetryInvocationContext otelContext, bool invokeCommands); | ||
void StartFunctionsLoggingListener(bool invokeCommands); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.