Ignore function load requests with duplicate FunctionId values #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnatoliB
added a commit
to AnatoliB/azure-functions-powershell-worker
that referenced
this pull request
Jul 15, 2019
…#278) * Add FunctionLoader IsLoaded method * Return from ProcessFunctionLoadRequest early if already loaded
AnatoliB
added a commit
to AnatoliB/azure-functions-powershell-worker
that referenced
this pull request
Jul 15, 2019
…#278) * Add FunctionLoader IsLoaded method * Return from ProcessFunctionLoadRequest early if already loaded
AnatoliB
added a commit
that referenced
this pull request
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mitigates issue #276.
The PowerShell worker seems to be relying on a guarantee that has never been explicitly provided by the Azure Functions host. Recently, the PowerShell worker started receiving more than one function load request with the same FunctionId. Apparently, this is caused by a change on the Azure Functions host side, and the root cause and the overall effect of this change are still to be investigated. In the meantime, we want to let the PowerShell worker tolerate this situation, which will make the load request operation idempotent.