Adding "WorkerStatus" capability #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alrod -- Thank you for making this change. After the PR is merged, I will port this change to the PowerShell language worker |
Francisco-Gamino
pushed a commit
that referenced
this pull request
Apr 5, 2022
7 tasks
Francisco-Gamino
pushed a commit
that referenced
this pull request
Apr 5, 2022
7 tasks
Francisco-Gamino
pushed a commit
that referenced
this pull request
Apr 5, 2022
This was referenced Apr 6, 2022
Francisco-Gamino
added a commit
that referenced
this pull request
Apr 6, 2022
Co-authored-by: Alexey Rodionov <[email protected]>
Francisco-Gamino
added a commit
that referenced
this pull request
Apr 6, 2022
Co-authored-by: Alexey Rodionov <[email protected]>
Francisco-Gamino
added a commit
that referenced
this pull request
Apr 7, 2022
Co-authored-by: Alexey Rodionov <[email protected]>
davidmrdavid
pushed a commit
that referenced
this pull request
Apr 7, 2022
fran38
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #785
PowerShell supports WorkerStatus requests but function hosts does not call the api as there is no corresponding capability:
PowerShell worker WorkerStatus support:
https://github.com/Azure/azure-functions-powershell-worker/blob/dev/src/RequestProcessor.cs#L57
Function Host check for WorkerStatus capability:
https://github.com/Azure/azure-functions-host/blob/dev/src/WebJobs.Script.Grpc/Channel/GrpcWorkerChannel.cs#L162