Support ASGI middleware chains by only yielding http.disconnect when response has been fully received #153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where
http.disconnect
would be sent even though the ASGI middleware hadn't received the whole response, which yielded empty responses.This was shown with 2 or more pieces of FastAPI middleware because it would send them in chunks.
As per the ASGI spec,
http.disconnect
should be sent when:So the receive method has been changed to only send then when all response body has been added to the buffer.
Fixes Azure/azure-functions-python-worker#1104