Adding new to_dict method for Document #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
requested review from
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
Codecov Report
@@ Coverage Diff @@
## dev #171 +/- ##
==========================================
- Coverage 90.36% 90.31% -0.06%
==========================================
Files 53 53
Lines 3031 3036 +5
Branches 802 803 +1
==========================================
+ Hits 2739 2742 +3
- Misses 215 217 +2
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| def to_dict(self) -> dict: | ||
| """Return the document as a dict - directly using self would also work | ||
| as Document is ``UserDict`` subclass and behave like dict""" | ||
| return dict(self) |
There was a problem hiding this comment.
Do we need to add a test for this?
There was a problem hiding this comment.
We don't have direct way of testing to_json, to_dict and other library methods. This is actually raising that we should have unittests for them as well.
gavin-aguiar
approved these changes
Feb 28, 2023
pdthummar
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #170