Skip to content

Added validation for route name for http triggers #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 16, 2022

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Jun 23, 2022

Description

Added validation for route name for http triggers

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #1066 (880dc9b) into dev (00a907b) will increase coverage by 0.28%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1066      +/-   ##
==========================================
+ Coverage   83.79%   84.08%   +0.28%     
==========================================
  Files          34       34              
  Lines        1858     1866       +8     
  Branches      299      300       +1     
==========================================
+ Hits         1557     1569      +12     
+ Misses        235      232       -3     
+ Partials       66       65       -1     
Flag Coverage Δ
unittests 84.08% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/functions.py 96.21% <100.00%> (+0.17%) ⬆️
azure_functions_worker/dispatcher.py 89.12% <0.00%> (+1.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghost ghost removed the needs-author feedback label Aug 15, 2022
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/validate_route_name branch from 5dad7f2 to 0e005c7 Compare August 15, 2022 20:16
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/validate_route_name branch from 0e005c7 to f064fff Compare August 15, 2022 20:25
@gavin-aguiar gavin-aguiar merged commit 2a2ccbf into dev Aug 16, 2022
@gavin-aguiar gavin-aguiar deleted the gaaguiar/validate_route_name branch August 16, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants