Skip to content

Fixing format_traceback's change of signature #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Oct 18, 2022

Description

The signature for format_traceback for Python 3.10 has changed and is a breaking change. This PR addresses that breakage and also adds a test to validate it.

For Python 3.`0 - https://docs.python.org/3/library/traceback.html#traceback.print_exception

Changed in version 3.10: The etype parameter has been renamed to exc and is now positional-only.

image

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr force-pushed the vameru/fix-traceback-formatting branch from 94f44bb to 024116d Compare October 18, 2022 04:07
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #1123 (699330a) into dev (9289105) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##              dev    #1123      +/-   ##
==========================================
- Coverage   85.09%   85.07%   -0.03%     
==========================================
  Files          33       33              
  Lines        1845     1849       +4     
  Branches      273      275       +2     
==========================================
+ Hits         1570     1573       +3     
- Misses        205      206       +1     
  Partials       70       70              
Flag Coverage Δ
unittests 85.07% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/logging.py 43.39% <33.33%> (+2.57%) ⬆️
azure_functions_worker/utils/common.py 100.00% <100.00%> (ø)
azure_functions_worker/dispatcher.py 88.94% <0.00%> (-0.27%) ⬇️
azure_functions_worker/extension.py 99.08% <0.00%> (+0.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vrdmr vrdmr force-pushed the vameru/fix-traceback-formatting branch from 024116d to 6b8a330 Compare October 18, 2022 05:35
@vrdmr vrdmr merged commit 6c5613d into dev Oct 18, 2022
@vrdmr vrdmr deleted the vameru/fix-traceback-formatting branch October 18, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants