Skip to content

Handling multi worker scenerio for pystein #1142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Nov 9, 2022

Description

Change to index the function in the load request. This is for cases where we have more than one worker. Since only the first worker calls the metadata request and the subsequent workers call the load request directly, we need to index the functions for worker2 and onwards in the load request.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #1142 (02499f3) into dev (28e5fdb) will decrease coverage by 0.10%.
The diff coverage is 84.61%.

❗ Current head 02499f3 differs from pull request most recent head 01b6ee0. Consider uploading reports for the commit 01b6ee0 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1142      +/-   ##
==========================================
- Coverage   84.97%   84.86%   -0.11%     
==========================================
  Files          32       32              
  Lines        1817     1824       +7     
  Branches      275      276       +1     
==========================================
+ Hits         1544     1548       +4     
- Misses        203      204       +1     
- Partials       70       72       +2     
Flag Coverage Δ
unittests 84.81% <84.61%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/loader.py 84.70% <ø> (-0.36%) ⬇️
azure_functions_worker/dispatcher.py 88.86% <81.81%> (-0.36%) ⬇️
azure_functions_worker/functions.py 96.27% <100.00%> (+0.06%) ⬆️
azure_functions_worker/extension.py 98.16% <0.00%> (-0.92%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@pdthummar pdthummar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. tested e2e tests with multiple worker process count for Pystein.

@gavin-aguiar gavin-aguiar merged commit 9a58193 into dev Nov 16, 2022
@gavin-aguiar gavin-aguiar deleted the gaaguiar/multi-worker-fix branch November 16, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants