Skip to content

Added worker metadata to init and reload response #1166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Jan 23, 2023

Description

Added worker metadata to WorkerInitResponse and FunctionEnvironmentReloadResponse

Fixes #1057


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1166 (1428412) into dev (d7e5c84) will decrease coverage by 51.96%.
The diff coverage is 75.00%.

❗ Current head 1428412 differs from pull request most recent head eed67bb. Consider uploading reports for the commit eed67bb to get more accurate results

@@             Coverage Diff             @@
##              dev    #1166       +/-   ##
===========================================
- Coverage   83.87%   31.92%   -51.96%     
===========================================
  Files          34       34               
  Lines        1885     1889        +4     
  Branches      362      275       -87     
===========================================
- Hits         1581      603      -978     
- Misses        233     1285     +1052     
+ Partials       71        1       -70     
Flag Coverage Δ
unittests 31.92% <75.00%> (-51.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/protos/__init__.py 100.00% <ø> (ø)
azure_functions_worker/dispatcher.py 19.74% <75.00%> (-69.12%) ⬇️
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 25.00% <0.00%> (-71.28%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-57.85%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@YunchuWang
Copy link
Member

#1057

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the test to check values within Metadata.

LGTM otherwise.

@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/add_metadata_in_init branch from 359a3f9 to 4ef7f32 Compare January 27, 2023 17:03
@gavin-aguiar gavin-aguiar merged commit 62b11cf into dev Jan 30, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/add_metadata_in_init branch January 30, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate WorkerMetadata in WorkerInitResponse message
3 participants