Skip to content

Move importing azfunc to init request #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 3, 2023
Merged

Conversation

gavin-aguiar
Copy link
Contributor

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #1170 (62b064d) into dev (a858fbf) will decrease coverage by 52.59%.
The diff coverage is 20.00%.

❗ Current head 62b064d differs from pull request most recent head 82806db. Consider uploading reports for the commit 82806db to get more accurate results

@@             Coverage Diff             @@
##              dev    #1170       +/-   ##
===========================================
- Coverage   84.48%   31.90%   -52.59%     
===========================================
  Files          34       34               
  Lines        1889     1893        +4     
  Branches      276      365       +89     
===========================================
- Hits         1596      604      -992     
- Misses        225     1288     +1063     
+ Partials       68        1       -67     
Flag Coverage Δ
unittests 31.90% <20.00%> (-52.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 19.59% <0.00%> (-69.39%) ⬇️
azure_functions_worker/constants.py 100.00% <100.00%> (ø)
...e_functions_worker/bindings/nullable_converters.py 21.62% <0.00%> (-78.38%) ⬇️
azure_functions_worker/functions.py 25.00% <0.00%> (-71.28%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
.../shared_memory_data_transfer/file_accessor_unix.py 19.60% <0.00%> (-65.69%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...ared_memory_data_transfer/shared_memory_manager.py 26.80% <0.00%> (-55.68%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gavin-aguiar gavin-aguiar marked this pull request as ready for review February 21, 2023 22:00
@gavin-aguiar gavin-aguiar merged commit 041fbce into dev Mar 3, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/move_import_to_init branch March 3, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants