Skip to content

Moving get_bindings_registry to static list #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 16, 2023

Conversation

gavin-aguiar
Copy link
Contributor

@gavin-aguiar gavin-aguiar commented Mar 14, 2023

Description

Fixes #1179


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1197 (c67afce) into dev (c403eab) will decrease coverage by 52.42%.
The diff coverage is 42.85%.

❗ Current head c67afce differs from pull request most recent head 774ecea. Consider uploading reports for the commit 774ecea to get more accurate results

@@             Coverage Diff             @@
##              dev    #1197       +/-   ##
===========================================
- Coverage   84.42%   32.00%   -52.42%     
===========================================
  Files          34       34               
  Lines        1900     1903        +3     
  Branches      366      366               
===========================================
- Hits         1604      609      -995     
- Misses        229     1293     +1064     
+ Partials       67        1       -66     
Flag Coverage Δ
unittests 32.00% <42.85%> (-52.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 19.44% <0.00%> (-69.65%) ⬇️
azure_functions_worker/bindings/meta.py 26.19% <50.00%> (-58.15%) ⬇️
azure_functions_worker/bindings/__init__.py 100.00% <100.00%> (ø)

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/get_bindings_revamp branch from 2a85f05 to 9013f9f Compare March 14, 2023 22:11
@gavin-aguiar gavin-aguiar marked this pull request as ready for review March 15, 2023 20:21
@gavin-aguiar gavin-aguiar force-pushed the gaaguiar/get_bindings_revamp branch from 9e0df09 to bf61cb7 Compare March 16, 2023 01:35
@gavin-aguiar gavin-aguiar merged commit 91f0d4a into dev Mar 16, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/get_bindings_revamp branch March 16, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

partially initialized module 'azure.functions' has no attribute 'get_binding_registry'
2 participants