Skip to content

Update e2e tests GH workflow to fix flaky tests. #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2023
Merged

Conversation

pdthummar
Copy link
Contributor

Description

Fixes #1275 . This will fix the flaky PTPTC and FWPC e2e tests


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1276 (4e06138) into dev (36837ac) will decrease coverage by 52.63%.
The diff coverage is n/a.

❗ Current head 4e06138 differs from pull request most recent head 35dead4. Consider uploading reports for the commit 35dead4 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1276       +/-   ##
===========================================
- Coverage   84.61%   31.98%   -52.63%     
===========================================
  Files          34       34               
  Lines        1904     1904               
  Branches      366      366               
===========================================
- Hits         1611      609     -1002     
- Misses        227     1294     +1067     
+ Partials       66        1       -65     
Flag Coverage Δ
unittests 31.98% <ø> (-52.58%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 24 files with indirect coverage changes

@pdthummar pdthummar changed the title Update e2e tests GH workflow to utilize shell script. Update e2e tests GH workflow to fix flaky tests. Jun 23, 2023
@vrdmr vrdmr merged commit cd16cf0 into dev Jun 24, 2023
@vrdmr vrdmr deleted the pthummar/update_GH_wf branch June 24, 2023 06:36
gavin-aguiar pushed a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PTPTC and FWPC flaky tests
2 participants