-
Notifications
You must be signed in to change notification settings - Fork 107
Reload modules when not in placeholder mode #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1340 +/- ##
===========================================
- Coverage 85.96% 32.18% -53.79%
===========================================
Files 34 34
Lines 1938 1942 +4
Branches 366 366
===========================================
- Hits 1666 625 -1041
- Misses 205 1316 +1111
+ Partials 67 1 -66
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vrdmr
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In linux consumption, when the host restarts the python worker due to any reason (timeout/OOM..), the host does not send an EnvironmentReload request since it assumes that the container has already been specialized. Due to this customer modules are not loaded and that causes the function app to fail with ModuleNotFound errors.
Fix here is to load customer modules when the container is not in placeholder mode for linux consumption.
Fixes #1350
PR information
Quality of Code and Contribution Guidelines