fix: update typing inspect get_origin check #1691
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: for 3.13, we will need a new library worker release with this change
Description
Previously, this was the check in
get_function_return_type
:If
typing_inspect.get_origin(return_anno)
returnedNone
, there would be an error thrown sayingAttributeError: 'NoneType' object has no attribute '__name__'
.This change introduces a new check to ensure that
typing_inspect.get_origin(return_anno)
is notNone
before checking the__name__
property.Fixes #1688
PR information
Quality of Code and Contribution Guidelines