Skip to content

Setting PTPTC to None for Py3.9 only #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Setting PTPTC to None for Py3.9 only #791

merged 4 commits into from
Dec 11, 2020

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Dec 10, 2020

Description

  • Made the changes for Python 3.9 only.
  • Added tests for verifying that the default is None only for Py3.9 and not for others.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

- Made the changes for Python 3.9 only.
- Added tests for verifying that the default is None only for Py3.9 and not for others.
@vrdmr vrdmr force-pushed the vameru/ptptc-to-none-py39 branch from 4241deb to a2fcb2b Compare December 10, 2020 09:44
@vrdmr vrdmr force-pushed the vameru/ptptc-to-none-py39 branch from a2fcb2b to d2e4cbc Compare December 10, 2020 09:59
@Hazhzeng
Copy link
Contributor

Python 3.6 CI is failing, please check

@vrdmr vrdmr merged commit 67fe2e3 into dev Dec 11, 2020
@vrdmr vrdmr deleted the vameru/ptptc-to-none-py39 branch December 11, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants