-
Notifications
You must be signed in to change notification settings - Fork 107
Implemented capability to isolate worker dependencies #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea329f1
to
3b4c737
Compare
I tried many ways to isolate the environment variable changes impact on other tests, but only find separating the testing file works. Let me know if you have any questions on this one. |
fee5af1
to
6bb4e9e
Compare
vrdmr
reviewed
Jan 8, 2021
7db2a04
to
49156fb
Compare
vrdmr
reviewed
Jan 12, 2021
vrdmr
approved these changes
Jan 13, 2021
8cab997
to
432ce7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #789
The new feature is implemented under PYTHON_ISOLATE_WORKER_DEPENDENCIES feature flag.
This PR is to introduce a capability to separate customer's site-packages from worker's dependencies.
We create a wrapper for loading the modules and ensure the sys.path and sys.modules have consistent content (invalidate overlapped cache) as the worker begin loading customer's code.
This will permanently address the issue when we bump up protobuf version in the future Python worker when customer is using an old version of protobuf.
When the new flag is set, we should see the following logging entries:
Reloaded azure google namespace from customer dependencies
Start using customer dependencies {cls.cx_deps_path}
PR information
Quality of Code and Contribution Guidelines