Skip to content

Add dotnet 5.0.x in CI pipeline to fix errors #901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 20, 2021
Merged

Add dotnet 5.0.x in CI pipeline to fix errors #901

merged 4 commits into from
Oct 20, 2021

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Oct 20, 2021

Description

There was some change in the Host which caused it to start breaking due to a non-preview feature being used. As the host is built to be used in the tests, this needed fixing.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr requested a review from AnatoliB as a code owner October 20, 2021 06:52
@vrdmr vrdmr merged commit 8f03839 into dev Oct 20, 2021
@vrdmr vrdmr deleted the vameru/dotnet-50x branch October 20, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnatoliB AnatoliB AnatoliB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vrdmr @AnatoliB