Skip to content

fix host_out readlines in test_utils #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

YunchuWang
Copy link
Member

Description

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #971 (09c8809) into dev (401801f) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #971      +/-   ##
==========================================
- Coverage   81.04%   81.01%   -0.03%     
==========================================
  Files          35       35              
  Lines        2337     2339       +2     
  Branches      370      371       +1     
==========================================
+ Hits         1894     1895       +1     
  Misses        337      337              
- Partials      106      107       +1     
Flag Coverage Δ
unittests 80.97% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/testutils.py 73.43% <66.66%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401801f...09c8809. Read the comment docs.

@vrdmr
Copy link
Member

vrdmr commented Mar 3, 2022

Closing in favor of #976

@vrdmr vrdmr closed this Mar 3, 2022
@vrdmr vrdmr deleted the wangbill/fix_host_out branch March 3, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants