-
Notifications
You must be signed in to change notification settings - Fork 4k
PS cosmos db restore command: Skipping client side restore validation check #28171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes client-side validation checks for restorable accounts in the PowerShell Cosmos DB restore command to address location format mismatches and prevent timeouts during large account restores.
- Removes the validation logic that checks if source accounts contain restorable resources for live accounts
- Eliminates the
isSourceRestorableAccountDeleted
variable and related conditional logic - Streamlines the restore process by bypassing client-side validation that was causing issues
Question for powershell team reviewers, how do i upgrade the version of this change? so, the customer would know which version to update to for this change to take efffect. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @dsapaliga, please update the changelog or the change will not be released. |
The tests of this source code are skipped. Could you please test them and provide the test result? |
I have not found any reference to the DateTime.ToString(), my changes currently remove that section of code entirely, I have remove the skip from tests. |
@microsoft-github-policy-service agree company="Microsoft" |
Updated the changelog, please validate if it looks good, thank you. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Commenter does not have sufficient privileges for PR 28171 in repo Azure/azure-powershell |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @dsapaliga, let's handle the "skip" tests later. For this PR, please provide a screenshot of test, just let us know the result is OK. |
Description
This is a simple fix to remove the validation check for restorable accounts when the customer uses the powershell restore command. Couple of reason for removing this:
This change is already part of cli-preview, updating this for powershell stable now.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.