Skip to content

[PS][Monitor] Add Breaking Change Message for DiagnosticSetting #28215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Jul 18, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@JoyerJin JoyerJin marked this pull request as ready for review July 21, 2025 07:13
@Copilot Copilot AI review requested due to automatic review settings July 21, 2025 07:13
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds breaking change warning messages for DiagnosticSetting cmdlets to notify users about upcoming changes to output property types. The changes prepare for a future release where certain properties will change from fixed arrays to List types.

  • Adds breaking change directives to the README.md configuration for DiagnosticSetting cmdlets
  • Updates solution file to reorganize DiagnosticSetting project references with new GUIDs
  • Adds DiagnosticSetting cmdlets to the changelog under upcoming release notes

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Monitor/Monitor/ChangeLog.md Adds DiagnosticSetting cmdlets to the upcoming release notes
src/Monitor/Monitor.sln Reorganizes DiagnosticSetting project references and updates project GUIDs
src/Monitor/DiagnosticSetting.Autorest/README.md Adds breaking change warning directives for property type changes
src/Monitor/DiagnosticSetting.Autorest/docs/Az.DiagnosticSetting.md Updates module GUID
src/Monitor/DiagnosticSetting.Autorest/generate-info.json Updates generation ID
src/Monitor/DiagnosticSetting.Autorest/Properties/AssemblyInfo.cs Adds new assembly information file
src/Monitor/DiagnosticSetting.Autorest/resources/README.md Adds new resources directory documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant