Skip to content

Updates to supported versions, handing Template deprecation in NiFi-2.x, and Windows development support #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

Chaffelson
Copy link
Owner

  • Tested against NiFi-1.28.1 and 2.2.0.
  • Bumped minimum Python3 version to 3.9 in line with Python retirement dates. Minor linting fixes.
  • Corrected version checks for Templates deprecation in NiFi-2.x
  • Added catcher for attempting to call Template functions against NiFi-2.x throwing new nipyapi.utils.VersionError, updated tests to match.
  • Library should now throw VersionError for client-server mismatch instead of generic ValueError with a 404 Not Found inherited from Requests.
  • Resolved fixture issues related to template create/destroy operations during pytest execution.
  • Switched default Controller Service Type to CSVReader from DistributedMapCacheClientService as it is present in all tested versions.

….x, and Windows development support.

Tested against NiFi-1.28.1 and 2.2.0.
Bumped minimum Python3 version to 3.9 in line with Python retirement dates.
Minor linting fixes.
Corrected version checks for Templates deprecation in NiFi-2.x
Added catcher for attempting to call Template functions against NiFi-2.x throwing new nipyapi.utils.VersionError, updated tests to match.
Library should now throw VersionError for client-server mismatch instead of generic ValueError with a 404 Not Found inherited from Requests.
Resolved fixture issues related to template create/destroy operations during pytest execution.
Switched default Controller Service Type to CSVReader from DistributedMapCacheClientService as it is present in all tested versions.
Copy link
Collaborator

@ottobackwards ottobackwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'm not sure if raising different errors / exceptions constitutes a breaking API change with regards to SEM versioingin

@ottobackwards ottobackwards merged commit c7d2564 into main Feb 26, 2025
1 check passed
@Chaffelson
Copy link
Owner Author

I'm not sure if raising different errors / exceptions constitutes a breaking API change with regards to SEM versioning

I think technically it would, but given the previous error wasn't very good and probably unused by anyone but us, I'm not too worried about it.

@dleditschke
Copy link

When is the next release planned?

@Chaffelson
Copy link
Owner Author

When is the next release planned?

I'm working on mTLS support for the 1.x line, and then a release on that. Then I'll turn to the 2.x rewrite.

Is there a particular feature you're looking for?

@dleditschke
Copy link

When is the next release planned?

I'm working on mTLS support for the 1.x line, and then a release on that. Then I'll turn to the 2.x rewrite.

Is there a particular feature you're looking for?

No particular features. I'm migrating a few NiFis from 1.19.1 to 1.28.1 before we start the big migration to 2.x so it's good to know that version is officially supported

@Chaffelson Chaffelson deleted the 20250224_updates branch March 7, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants