character set => move logic into parser #12
Conversation
| export class CharacterSetMatcher extends Matcher { | ||
| constructor(public set: string, public negated: bool) { | ||
| constructor(public matchers: Matcher[], public negated: bool) { |
There was a problem hiding this comment.
@MaxGraey - I've hit a funny error here, wondering if you might know the root cause?
RuntimeError: unreachable
at assembly/nfa/matcher/Matcher#matches@virtual (wasm-function[240]:1)
at assembly/nfa/matcher/CharacterSetMatcher#matches~anonymous|0 (wasm-function[241]:19)
at ~lib/array/Array<assembly/nfa/matcher/Matcher>#some (wasm-function[242]:85)
at assembly/nfa/matcher/CharacterSetMatcher#matches (wasm-function[244]:21)
at assembly/nfa/nfa/MatcherState<assembly/nfa/matcher/CharacterSetMatcher>#matches (wasm-function[245]:8)
at assembly/nfa/nfa/State#matches@virtual (wasm-function[250]:58)
at assembly/regexp/recursiveBacktrackingSearch (wasm-function[184]:121)
at assembly/regexp/recursiveBacktrackingSearch@varargs (wasm-function[185]:56)
at assembly/regexp/RegExp#exec (wasm-function[192]:307)
works just fine in TS/JS
There was a problem hiding this comment.
Hmm, hard to tell. Need minimal repro
There was a problem hiding this comment.
I tried reproduce this issue in minimal example but can't:
playground
There was a problem hiding this comment.
Unfortunately I think finding a minimal reproduction could be a challenge. I tried a similar approach, but couldn't reproduce.
What I have found is that adding the following block of code, executed before the RegExp is created, removes the error:
1592687#diff-f350832f4859b9724e3ef59f756d2d201226fd81fd797207367fc269581115adR171-R179
There was a problem hiding this comment.
I've raised an issue here AssemblyScript/assemblyscript#1635
ColinEberhardt
force-pushed
the
char-set-parser
branch
from
0afe911 to
1592687
Compare
ColinEberhardt
force-pushed
the
char-set-parser
branch
from
a459777 to
8bb9a18
Compare
ColinEberhardt
force-pushed
the
char-set-parser
branch
from
8bb9a18 to
bc8bc1f
Compare
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.