Skip to content

Remove requests for urllib #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maxday
Copy link
Contributor

@maxday maxday commented Aug 26, 2021

requests is too heavy and slows down coldstart

Motivation

performance optimization

Testing Guidelines

unit + integration tests

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@maxday maxday requested a review from a team as a code owner August 26, 2021 22:57
@nhinsch
Copy link
Contributor

nhinsch commented Aug 26, 2021

I think it would be cleaner to just go ahead and drop support for Python 2.7 now. It's not going to be possible to update Python 2.7 Lambda functions starting one month from now. Customers with Python 2.7 functions would just have to stay on the older library version for the remaining month of support. We did something similar with Node 10.

We could make another PR dropping support for Python 2.7 and then follow up with this one.

Copy link
Contributor

@nhinsch nhinsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if we want to keep support for Python 2.7 for now

@maxday maxday merged commit cb7b244 into maxday/prepare-remove-requests Aug 27, 2021
@maxday maxday deleted the maxday/remove-requests-for-urllib branch August 27, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants