Skip to content

Commit 786c914

Browse files
authored
Expand ownership of Version Bump related files (#6877)
## Summary of changes Expand the ownership of [Version Bump](#6875 files to be reviewable by https://github.com/orgs/DataDog/teams/apm-dotnet ## Reason for change Several of the files require reviews from https://github.com/orgs/DataDog/teams/profiling-dotnet, which has limited coverage. ## Implementation details I reviewed this recent [Version Bump PR](#6875) file-by-file, hovered over the little "shield" icon and added the file to the `CODEOWNERS` if it wasn't already owned by `@apm-dotnet`. All of the new entries with JUST `@apm-dotnet` were previously owned by `@tracing-dotnet`. All of the new entries with `@DataDog/profiling-dotnet @DataDog/apm-dotnet` were previously owned by JUST `@DataDog/profiling-dotnet` ## Test coverage ## Other details This isn't ideal, but I don't see a better way around it without just force merging. <!-- Fixes #{issue} --> <!-- ⚠️ Note: where possible, please obtain 2 approvals prior to merging. Unless CODEOWNERS specifies otherwise, for external teams it is typically best to have one review from a team member, and one review from apm-dotnet. Trivial changes do not require 2 reviews. -->
1 parent 85a2d6a commit 786c914

File tree

1 file changed

+35
-0
lines changed

1 file changed

+35
-0
lines changed

.github/CODEOWNERS

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,3 +172,38 @@ missing-nullability-files.csv @DataDog/apm-dotnet
172172
/tracer/src/Datadog.Trace/Configuration/IntegrationId.cs @DataDog/apm-dotnet
173173
/tracer/src/Datadog.Trace/Telemetry/Metrics/MetricTags.cs @DataDog/apm-dotnet
174174
/tracer/src/Datadog.Trace/Telemetry/Metrics/IntegrationIdExtensions.cs @DataDog/apm-dotnet
175+
176+
# Version Bump Related Files - overriding to have wider coverage
177+
178+
/profiler/src/ProfilerEngine/Datadog.Linux.ApiWrapper/CMakeLists.txt @DataDog/profiling-dotnet @DataDog/apm-dotnet
179+
/profiler/src/ProfilerEngine/Datadog.Profiler.Native.Linux/CMakeLists.txt @DataDog/profiling-dotnet @DataDog/apm-dotnet
180+
/profiler/src/ProfilerEngine/Datadog.Profiler.Native.Windows/Resource.rc @DataDog/profiling-dotnet @DataDog/apm-dotnet
181+
/profiler/src/ProfilerEngine/Datadog.Profiler.Native/dd_profiler_version.h @DataDog/profiling-dotnet @DataDog/apm-dotnet
182+
/profiler/src/ProfilerEngine/ProductVersion.props @DataDog/profiling-dotnet @DataDog/apm-dotnet
183+
/tracer/samples/AutomaticTraceIdInjection/Log4NetExample/Log4NetExample.csproj @DataDog/apm-dotnet
184+
/tracer/samples/AutomaticTraceIdInjection/MicrosoftExtensionsExample/MicrosoftExtensionsExample.csproj @DataDog/apm-dotnet
185+
/tracer/samples/AutomaticTraceIdInjection/NLog40Example/NLog40Example.csproj @DataDog/apm-dotnet
186+
/tracer/samples/AutomaticTraceIdInjection/NLog45Example/NLog45Example.csproj @DataDog/apm-dotnet
187+
/tracer/samples/AutomaticTraceIdInjection/NLog46Example/NLog46Example.csproj @DataDog/apm-dotnet
188+
/tracer/samples/AutomaticTraceIdInjection/SerilogExample/SerilogExample.csproj @DataDog/apm-dotnet
189+
/tracer/samples/ConsoleApp/Alpine3.10.dockerfile @DataDog/apm-dotnet
190+
/tracer/samples/ConsoleApp/Alpine3.9.dockerfile @DataDog/apm-dotnet
191+
/tracer/samples/ConsoleApp/Debian.dockerfile @DataDog/apm-dotnet
192+
/tracer/samples/OpenTelemetry/Debian.dockerfile @DataDog/apm-dotnet
193+
/tracer/samples/WindowsContainer/Dockerfile @DataDog/apm-dotnet
194+
/tracer/src/Datadog.Trace.BenchmarkDotNet/Datadog.Trace.BenchmarkDotNet.csproj @DataDog/apm-dotnet
195+
/tracer/src/Datadog.Trace.Bundle/Datadog.Trace.Bundle.csproj @DataDog/apm-dotnet
196+
/tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Datadog.Trace.ClrProfiler.Managed.Loader.csproj @DataDog/apm-dotnet
197+
/tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Startup.cs @DataDog/apm-dotnet
198+
/tracer/src/Datadog.Trace.MSBuild/Datadog.Trace.MSBuild.csproj @DataDog/apm-dotnet
199+
/tracer/src/Datadog.Trace.Manual/Datadog.Trace.Manual.csproj @DataDog/apm-dotnet
200+
/tracer/src/Datadog.Trace.OpenTracing/Datadog.Trace.OpenTracing.csproj @DataDog/apm-dotnet
201+
/tracer/src/Datadog.Trace.Tools.Runner/Datadog.Trace.Tools.Runner.csproj @DataDog/apm-dotnet
202+
/tracer/src/Datadog.Trace.Tools.dd_dotnet/Datadog.Trace.Tools.dd_dotnet.csproj @DataDog/apm-dotnet
203+
/tracer/src/Datadog.Trace.Trimming/Datadog.Trace.Trimming.csproj @DataDog/apm-dotnet
204+
/tracer/src/Datadog.Trace/Datadog.Trace.csproj @DataDog/apm-dotnet
205+
/tracer/src/Datadog.Trace/TracerConstants.cs @DataDog/apm-dotnet
206+
/tracer/src/Datadog.Tracer.Native/CMakeLists.txt @DataDog/apm-dotnet
207+
/tracer/src/Datadog.Tracer.Native/Resource.rc @DataDog/apm-dotnet
208+
/tracer/src/Datadog.Tracer.Native/dd_profiler_constants.h @DataDog/apm-dotnet
209+
/tracer/tools/PipelineMonitor/PipelineMonitor.csproj @DataDog/apm-dotnet

0 commit comments

Comments
 (0)